[v12.x] deps: V8: cherry-pick cb1c2b0fbfe7 #31939

Flarna · 2020-02-24T22:14:54Z

Original commit message:

Remove noscript_shared_function_infos

SharedFunctionInfos that do not belong to a script were tracked in
noscript_shared_function_infos. However this was only used in object-stats.
Remove this since it was actually leaking memory in some use cases.

Bug: v8:9674
Change-Id: I9482f7e5dedf975666a70684b3d2ea04c9a23518
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798423
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63685}

Refs: v8/v8@cb1c2b0
Refs: #31914

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

mmarchini · 2020-03-03T22:21:04Z

17:44:05 #
17:44:05 # Fatal error in , line 0
17:44:05 # Check failed: CompareTexts(BuildActual(printer, snippets), LoadGolden("PrivateMethodAccess.golden")).
17:44:05 #

FWIW, this is a known failure (#32076)

Flarna · 2020-03-17T09:16:53Z

The CI failures looked strange. Rebased to get any relevant change in.

Flarna · 2020-03-17T15:26:36Z

CI fails because No space left on device

mmarchini · 2020-03-17T16:40:40Z

There are a lot of failures like this:

12:41:57 /home/iojs/build/workspace/node-test-commit-aix/nodes/aix71-ppc64/tools/doc/allhtml.js:87
12:41:57   if (!ids.has(match[1])) throw new Error(`link not found: ${match[1]}`);
12:41:57                           ^
12:41:57 
12:41:57 Error: link not found: repl_reverse_i_search
12:41:57     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix71-ppc64/tools/doc/allhtml.js:87:33)
12:41:57     at Module._compile (internal/modules/cjs/loader.js:1158:30)
12:41:57     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
12:41:57     at Module.load (internal/modules/cjs/loader.js:1002:32)
12:41:57     at Function.Module._load (internal/modules/cjs/loader.js:901:14)
12:41:57     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
12:41:57     at internal/main/run_main_module.js:18:47

Might be because of the rebase? I'm not sure

richardlau · 2020-03-17T16:44:39Z

There are a lot of failures like this:

12:41:57 /home/iojs/build/workspace/node-test-commit-aix/nodes/aix71-ppc64/tools/doc/allhtml.js:87
12:41:57   if (!ids.has(match[1])) throw new Error(`link not found: ${match[1]}`);
12:41:57                           ^
12:41:57 
12:41:57 Error: link not found: repl_reverse_i_search
12:41:57     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix71-ppc64/tools/doc/allhtml.js:87:33)
12:41:57     at Module._compile (internal/modules/cjs/loader.js:1158:30)
12:41:57     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
12:41:57     at Module.load (internal/modules/cjs/loader.js:1002:32)
12:41:57     at Function.Module._load (internal/modules/cjs/loader.js:901:14)
12:41:57     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
12:41:57     at internal/main/run_main_module.js:18:47

Might be because of the rebase? I'm not sure

Should be fixed by rebasing: #32282 (comment)

mmarchini · 2020-03-17T16:52:47Z

Ah, @Flarna rebased after the CI. I'll start it again

mmarchini · 2020-03-18T02:16:29Z

I mean, this is probably good to land, the last failing on Jenkins was infra-related, but let's try again just to be sure. @Flarna were you expecting this to be included in the next release?

Flarna · 2020-03-18T11:38:04Z

@mmarchini I was not targeting a specific release.
I created this PR simply because I saw the #31914 and found it's easy to fix - and a nice training for me to practice v8 back porting.

nodejs-github-bot · 2020-03-19T05:38:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29919/ ✔️

Flarna · 2020-03-26T12:47:53Z

Rebased to get rid of merge conflicts.

MylesBorins · 2020-04-01T06:23:55Z

@Flarna apologies but this requires another rebase. I've gone ahead and done the work but was unable to push to your branch.

https://github.com/MylesBorins/node/tree/backport-cb1c2b0

Original commit message: Remove noscript_shared_function_infos SharedFunctionInfos that do not belong to a script were tracked in noscript_shared_function_infos. However this was only used in object-stats. Remove this since it was actually leaking memory in some use cases. Bug: v8:9674 Change-Id: I9482f7e5dedf975666a70684b3d2ea04c9a23518 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798423 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#63685} Refs: v8/v8@cb1c2b0

Flarna · 2020-04-01T09:41:56Z

@MylesBorins Rebased
Not sure why you can't push to my branch. Most likely because the repo is part of an organization and not a personal fork.

nodejs-github-bot · 2020-04-01T17:00:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30331/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2986/

MylesBorins · 2020-04-01T19:42:24Z

Looks like this might introduce new failures on both regular CI and V8-CI. Running CI against staging to confirm

12.x-staging CI: https://ci.nodejs.org/job/node-test-commit/37126/
12.x-staging V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/2987/

mmarchini · 2020-04-01T20:08:49Z

@MylesBorins those are known, V8 CI on v12 is consistently failing, see comment above: #31939 (comment).

(I think I know how to fix it, will try later)

nodejs-github-bot · 2020-04-01T21:31:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30339/

Original commit message: Remove noscript_shared_function_infos SharedFunctionInfos that do not belong to a script were tracked in noscript_shared_function_infos. However this was only used in object-stats. Remove this since it was actually leaking memory in some use cases. Bug: v8:9674 Change-Id: I9482f7e5dedf975666a70684b3d2ea04c9a23518 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798423 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#63685} PR-URL: #31939 Refs: v8/v8@cb1c2b0 Refs: #31914 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

MylesBorins · 2020-04-02T03:50:42Z

landed in a83fc49

nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 24, 2020

bnoordhuis approved these changes Feb 25, 2020

View reviewed changes

mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020

This comment has been minimized.

Sign in to view

targos approved these changes Feb 29, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

mmarchini approved these changes Mar 3, 2020

View reviewed changes

Flarna mentioned this pull request Mar 5, 2020

Memory leak when using Intl.DateTimeFormat.format() and Intl.NumberFormat.format() #31914

Closed

This comment has been minimized.

Sign in to view

Flarna force-pushed the backport-cb1c2b0 branch from 928f179 to c7b94b6 Compare March 17, 2020 09:15

This comment has been minimized.

Sign in to view

codebytere force-pushed the v12.x-staging branch from a01fb4a to e5dc2fb Compare March 23, 2020 16:01

Flarna force-pushed the backport-cb1c2b0 branch 2 times, most recently from ecb1eb1 to ce374fe Compare March 26, 2020 11:28

codebytere force-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190 Compare March 31, 2020 23:57

Flarna force-pushed the backport-cb1c2b0 branch from ce374fe to 52a2813 Compare April 1, 2020 09:40

MylesBorins closed this Apr 2, 2020

Flarna deleted the backport-cb1c2b0 branch April 2, 2020 07:08

codebytere mentioned this pull request Apr 3, 2020

v12.16.2 proposal #32313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v12.x] deps: V8: cherry-pick cb1c2b0fbfe7 #31939

[v12.x] deps: V8: cherry-pick cb1c2b0fbfe7 #31939

Flarna commented Feb 24, 2020

This comment has been minimized.

This comment has been minimized.

mmarchini commented Mar 3, 2020

This comment has been minimized.

Flarna commented Mar 17, 2020

Flarna commented Mar 17, 2020

mmarchini commented Mar 17, 2020

richardlau commented Mar 17, 2020

mmarchini commented Mar 17, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mmarchini commented Mar 18, 2020 •

edited

Loading

Flarna commented Mar 18, 2020

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 19, 2020 •

edited by mmarchini

Loading

Flarna commented Mar 26, 2020

MylesBorins commented Apr 1, 2020

Flarna commented Apr 1, 2020

nodejs-github-bot commented Apr 1, 2020 •

edited by MylesBorins

Loading

MylesBorins commented Apr 1, 2020

mmarchini commented Apr 1, 2020 •

edited

Loading

nodejs-github-bot commented Apr 1, 2020

MylesBorins commented Apr 2, 2020

[v12.x] deps: V8: cherry-pick cb1c2b0fbfe7 #31939

[v12.x] deps: V8: cherry-pick cb1c2b0fbfe7 #31939

Conversation

Flarna commented Feb 24, 2020

Checklist

This comment has been minimized.

This comment has been minimized.

mmarchini commented Mar 3, 2020

This comment has been minimized.

Flarna commented Mar 17, 2020

Flarna commented Mar 17, 2020

mmarchini commented Mar 17, 2020

richardlau commented Mar 17, 2020

mmarchini commented Mar 17, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mmarchini commented Mar 18, 2020 • edited Loading

Flarna commented Mar 18, 2020

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 19, 2020 • edited by mmarchini Loading

Flarna commented Mar 26, 2020

MylesBorins commented Apr 1, 2020

Flarna commented Apr 1, 2020

nodejs-github-bot commented Apr 1, 2020 • edited by MylesBorins Loading

MylesBorins commented Apr 1, 2020

mmarchini commented Apr 1, 2020 • edited Loading

nodejs-github-bot commented Apr 1, 2020

MylesBorins commented Apr 2, 2020

mmarchini commented Mar 18, 2020 •

edited

Loading

nodejs-github-bot commented Mar 19, 2020 •

edited by mmarchini

Loading

nodejs-github-bot commented Apr 1, 2020 •

edited by MylesBorins

Loading

mmarchini commented Apr 1, 2020 •

edited

Loading