Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: revamp internal field count tracking #31960

Closed
wants to merge 1 commit into from
Closed

src: revamp internal field count tracking #31960

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 26, 2020

Improved handling of internal field counts.

In a separate PR, it would likely be good to switch to use of utility functions that include DCHECKs for the InternalFieldCount().

/cc @bnoordhuis @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 26, 2020
@jasnell jasnell mentioned this pull request Feb 26, 2020
Closed
2 tasks
addaleax
addaleax reviewed Feb 26, 2020
View reviewed changes
src/async_wrap.cc Outdated Show resolved Hide resolved
src/base_object-inl.h Outdated Show resolved Hide resolved
src/cares_wrap.cc Outdated Show resolved Hide resolved
@jasnell jasnell force-pushed the revamp-internal-field-count-tracking branch from 39f07a2 to ec851dc Compare February 26, 2020 03:29
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29366/

bnoordhuis
bnoordhuis reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is already much better than the current state of things and looks like it already exposes a few infidelities and at least one outright bug.

src/async_wrap.cc Outdated Show resolved Hide resolved
src/base_object.h Outdated Show resolved Hide resolved
src/node_object_wrap.h Outdated Show resolved Hide resolved
src/stream_base.h Show resolved Hide resolved
src/stream_base.h Show resolved Hide resolved
src/stream_wrap.cc Outdated Show resolved Hide resolved
addaleax
addaleax requested changes Feb 26, 2020
View reviewed changes
src/async_wrap.cc Outdated Show resolved Hide resolved
@addaleax addaleax mentioned this pull request Feb 26, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29391/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29397/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020
bnoordhuis
bnoordhuis approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with suggestions.

src/stream_base-inl.h Outdated Show resolved Hide resolved
src/stream_base.h Outdated Show resolved Hide resolved
src/stream_base.h Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29450/

@jasnell
src: improve handling of internal field counting
9c6e9cd 
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the revamp-internal-field-count-tracking branch from aa26581 to 9c6e9cd Compare February 29, 2020 01:46
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29453/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29487/

jasnell added a commit that referenced this pull request Mar 2, 2020
@jasnell
src: improve handling of internal field counting
0fac393 
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Mar 2, 2020 •
edited by addaleax
Loading

Landed in 0fac393

@jasnell jasnell closed this Mar 2, 2020
MylesBorins pushed a commit that referenced this pull request Mar 4, 2020
@jasnell @MylesBorins
src: improve handling of internal field counting
4d5318c 
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
Merged
@targos
Copy link
Member

targos commented Apr 20, 2020

Depends at least on #31569 to land on v12.x

@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: improve handling of internal field counting
d21f734 
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: improve handling of internal field counting
c979aea 
Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@fhinkel fhinkel fhinkel approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @targos @mcollina @fhinkel @bnoordhuis @addaleax