docs: replace all instances of node.js with io.js because trademark. #32
Conversation
|
Can we get rid of the "Evented I/O For V8 JavaScript" garbage while we're in there too? |
|
@rvagg that's already gone in the README, where else is it? |
| @@ -539,8 +539,8 @@ maintained libraries. The externally maintained libraries used by Node are: | |||
| -------- | |||
|
|
|||
|
|
|||
| "Node.js" and "node" trademark Joyent, Inc. npm is not officially | |||
| part of the Node.js project, and is neither owned by nor | |||
| "io.js" and "node" trademark Joyent, Inc. npm is not officially | |||
There was a problem hiding this comment.
Well this looks wrong :)
|
Do we need to s/nodejs/iojs/g too? Or only remove references to "node.js"? Not really across trademark laws. |
|
@SomeoneWeird are there instances where it makes sense to do this? We should be thorough in this unless it's too yak-shavy. @mikeal see src/res/node.rc - on current joyent/node it even shows up on the Windows process manager as "Evented I/O for V8 JavaScript" with no mention of "node", we have it fixed here and you're changing it to "io.js: Evented I/O for V8 JavaScript". I don't know what else to call it but anything would be better than that. |
rvagg
force-pushed
the
v0.12
branch
2 times, most recently
from
ef69bad
to
e36faf4
Compare
| @@ -149,6 +149,6 @@ not send out notifications when you add commits. | |||
|
|
|||
| [stability index page]: https://github.com/joyent/node/blob/master/doc/api/documentation.markdown | |||
|
this reaches down in to npm to make changes and probably shouldn't |
rvagg
force-pushed
the
v0.12
branch
2 times, most recently
from
d7e65ff
to
185d11c
Compare
|
Yeah, I think ./deps should be ignored, doesn't really make a whole lot of sense. |
| @@ -203,7 +203,7 @@ Client.prototype._addScript = function(desc) { | |||
| this.scripts[desc.id] = desc; | |||
| if (desc.name) { | |||
| desc.isNative = (desc.name.replace('.js', '') in natives) || | |||
| desc.name == 'node.js'; | |||
| desc.name == 'io.js'; | |||
There was a problem hiding this comment.
This should be reverted, it checks if the debugged file is src/node.js.
|
Okay, I'll stop repeating myself. :-) All changes to deps/ and some of the changes to src/ and test/ should be reverted. Run |
|
I'm closing this, it doesn't merge cleanly and is rife with problems. |
I doubt this is acceptable "as is" but it's a good starting point to talk about all the places the trademarked term "node.js" appears in the repo and what, in all, might need to be changed in order to remove it.