Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared brotli #32046

Closed
wants to merge 2 commits into from
Closed

Shared brotli #32046

wants to merge 2 commits into from

Commits on Mar 3, 2020

  1. build: allow passing multiple libs to pkg_config 

    Sometimes it's necessary to pass multiple library names to pkg-config,
e.g. the brotli shared libraries can be pulled in with
    pkg-config libbrotlienc libbrotlidec

Update the code to handle both, strings (as used so far), and lists
of strings.

Signed-off-by: André Draszik <git@andred.net>
    @andred
    andred committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    122ca47 View commit details
    Browse the repository at this point in the history

  2. build: allow use of system-installed brotli 

    brotli is available as a shared library since 2016, so it makes sense
to allow its use as a system-installed version.

Some of the infrastructure was in place already (node.gyp and
node.gypi), but some bits in the configure script here were missing.

Add them, keeping the default as before, to use the bundled version.

Refs: google/brotli#421
Signed-off-by: André Draszik <git@andred.net>
    @andred
    andred committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c7265f7 View commit details
    Browse the repository at this point in the history