Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: revise test-net-reconnect-error #32120

Merged
merged 2 commits into from
Mar 8, 2020
Merged

test: revise test-net-reconnect-error #32120

merged 2 commits into from
Mar 8, 2020

Commits on Mar 8, 2020

  1. test: apply camelCase in test-net-reconnect-error 

    Rename two idnetifiers that were snake_case rather than camelCase.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
    @Trott
    Trott committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    4c6ef4b View commit details
    Browse the repository at this point in the history

  2. test: remove superfluous checks in test-net-reconnect-error 

    The process.on('exit', ...) checks duplicate the work of
`common.mustCall()` and are superfluous. Remove them.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
    @Trott
    Trott committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    1b35e84 View commit details
    Browse the repository at this point in the history