Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_wrap: correctly pass parent to init callback #3216

Closed
wants to merge 1 commit into from

Commits on Oct 7, 2015

  1. async_wrap: correctly pass parent to init callback

    Previous logic didn't allow parent to propagate to the init callback
    properly. The fix now allows the init callback to be called and passed
    the parent if:
    
    - async wrap callbacks are enabled and parent exists
    - the init callback has been called on the parent and an init callback
      exists then it will be called regardless of whether async wrap
      callbacks are disabled.
    
    Change the init/pre/post callback checks to see if it has been properly
    set. This allows removal of the Environment "using_asyncwrap" variable.
    
    Pass Isolate to TryCatch instance.
    trevnorris committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    71568ea View commit details
    Browse the repository at this point in the history