stream: avoid destroying writable source #32198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we fast track this? I'd like to see it land in the upcoming 13.11.0 release @ronag looks like this needs a rebase |
MylesBorins
added
the
fast-track
ronag
force-pushed
the
stream-pipeline-destroy
branch
from
0506fd0 to
7b3eccc
Compare
|
rebased @MylesBorins |
jasnell
reviewed
Mar 11, 2020
| const src = new PassThrough(); | ||
| assert.strictEqual(src.writable, true); | ||
| const dst = new PassThrough(); | ||
| pipeline(src, dst, common.mustCall((err) => { |
There was a problem hiding this comment.
A test that has a Duplex piping back in to itself would be good also
There was a problem hiding this comment.
I suppose this is a nit? Since we might want to fast-track this would you mind if I do so in a follow up PR later?
jasnell
approved these changes
Mar 11, 2020
ronag
added
the
author ready
|
@ronag fwiw you can't approve fastrack on your own PR |
Np, I was +1 the rebase part of your comment. I'll remove my +1. |
|
+1 to fast tracking |
|
@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release. |
4 tasks
2 tasks
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Fixes: nodejs@4d93e10#commitcomment-37751035
|
Fixed conflicts |
ronag
force-pushed
the
stream-pipeline-destroy
branch
from
7b3eccc to
5daaddb
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Mar 12, 2020
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. PR-URL: #32198 Refs: 4d93e10#commitcomment-37751035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
landed in 2bfb340 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 12, 2020
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Backport-PR-URL: #32212 PR-URL: #32198 Refs: 4d93e10#commitcomment-37751035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.
Fixes: 4d93e10#commitcomment-37751035
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes