-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add help repo link to CONTRIBUTING.md #3233
Conversation
Direct help requests and technical issues that are not issues with Node.js to the nodejs help repo issue tracker. Add link. Fixes: nodejs#3185
@@ -6,6 +6,10 @@ When opening new issues or commenting on existing issues on this repository | |||
please make sure discussions are related to concrete technical issues with the | |||
Node.js software. | |||
|
|||
For technical issues related to using Node.js that are not issues with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of something more like this: For general help using Node.js, please file an issue at...
I think that may be easier to grok than issues related to using Node.js that are not issues with the Node.js software itself
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're probably right. I may have tried to go a bit to dry and technical with it. Should I do a new commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, go ahead with a second commit on top of this one. (You or I or someone else can squash 'em all down into one commit later.)
Thanks for tackling this, by the way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed. Thanks for being awesome!
Direct help requests and technical issues that are not issues with Node.js to the nodejs help repo issue tracker. Add link. Update Language. Fixes: nodejs#3185
@@ -6,6 +6,9 @@ When opening new issues or commenting on existing issues on this repository | |||
please make sure discussions are related to concrete technical issues with the | |||
Node.js software. | |||
|
|||
For general help using Node.js, please file an issue at the | |||
[nodejs help repository](https://github.com/nodejs/help/issues). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps use [Node.js help repository]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the nit. It's Node.js
in documentation and other prose so we should use that here.
Other than that, LGTM |
Direct help requests and technical issues that are not issues with Node.js to the nodejs help repo issue tracker. Add link. Update Language. Fixes: nodejs#3185
LGTM |
1 similar comment
LGTM |
Landed in 35cdded. Thanks for the contribution! |
landed in v4.x-staging in d4fc6d9 |
Direct help requests and technical issues that are not issues with
Node.js to the nodejs help repo issue tracker. Add link.
Fixes: #3185