build: add commit message linting to workflow #32336
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run linting on the commit message of the first commit in a pull
request as part of our GitHub actions CI workflow. If linting fails
the pull request will be labelled as requiring a fix to the commit
message. The check itself will always pass so as to not concern
first time contributors.
This is a different approach to the commit message linting that
is currently run on Travis CI. The new label introduced by this
pull request (
needs commit message fix
) could also be addedmanually for cases where the commit message needs updating
before landing for things not caught by
core-validate-commit
(e.g. typos). We can also teach
node-core-utils
to check for thelabel when landing pull requests (for those things not caught by
core-validate-commit
).Checklist