Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note re term-size commit on top of npm #32403

Closed

Commits on Mar 21, 2020

  1. doc: add note re term-size commit on top of npm

    Until npm updates update-notifier to a newer version, the dependency
    tree will contain a version of term-size that has an unsigned macOS
    binary. This will fail .pkg notarization and will result in failed
    release builds. We built and signed a term-size and contributed it back
    to the project for this purpose, but the dependency chain is long enough
    that it's not likely to be included in a new npm very quickly.
    Until it is, we need to cherry-pick commit d2f08a1 ontop of any npm
    updates to master and any other release branch that includes
    notarization.
    rvagg committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    f4521ec View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. fixup! doc: add note re term-size commit on top of npm

    Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
    rvagg and bnoordhuis authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    341550a View commit details
    Browse the repository at this point in the history
  2. fixup! doc: add note re term-size commit on top of npm

    Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
    rvagg and bnoordhuis authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    8a12af6 View commit details
    Browse the repository at this point in the history