src: cleanup DestroyParam when Environment exits #32421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, this leaks memory if the weak callback is never called.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Mar 22, 2020
devnexen
approved these changes
Mar 22, 2020
addaleax
added
the
author ready
jasnell
approved these changes
Mar 22, 2020
addaleax
added a commit
that referenced
this pull request
Mar 27, 2020
Otherwise, this leaks memory if the weak callback is never called. PR-URL: #32421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1b1c299 |
addaleax
added a commit
that referenced
this pull request
Mar 30, 2020
Otherwise, this leaks memory if the weak callback is never called. PR-URL: #32421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Otherwise, this leaks memory if the weak callback is never called. PR-URL: #32421 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, this leaks memory if the weak callback is never called.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes