Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.buildType in embedding test #32422

Closed
wants to merge 1 commit into from
Closed

test: use common.buildType in embedding test #32422

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This un-breaks testing in the case of ./configure --debug-node.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: use common.buildType in embedding test
7a4d967 
This un-breaks testing in the case of `./configure --debug-node`.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 22, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29980/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30090/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30122/

addaleax added a commit that referenced this pull request Mar 27, 2020
@addaleax
test: use common.buildType in embedding test
c3204a8 
This un-breaks testing in the case of `./configure --debug-node`.

PR-URL: #32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

Landed in c3204a8

@addaleax addaleax closed this Mar 27, 2020
@addaleax addaleax deleted the embedding-buildtype branch March 27, 2020 16:30
@addaleax addaleax mentioned this pull request Mar 30, 2020
Closed
4 tasks
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
@addaleax addaleax mentioned this pull request Sep 17, 2020
Closed
4 tasks
addaleax added a commit to addaleax/node that referenced this pull request Sep 23, 2020
@addaleax
test: use common.buildType in embedding test
b931e68 
This un-breaks testing in the case of `./configure --debug-node`.

PR-URL: nodejs#32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Sep 23, 2020
@addaleax
test: use common.buildType in embedding test
bd71cdf 
This un-breaks testing in the case of `./configure --debug-node`.

Backport-PR-URL: #35241
PR-URL: #32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @jasnell @lpinca @cjihrig @richardlau @targos