Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] Backport N-API 6 to v10.x #32488

Closed
wants to merge 2 commits into from
Closed

[v10.x] Backport N-API 6 to v10.x #32488

wants to merge 2 commits into from

Commits on Mar 25, 2020

  1. n-api: correct instance data tests 

    When instance data was backported, some of the tests ended up in a
location where they do not get run. This moves the tests into
test/addons-napi, merging them with existing tests therein, thereby
ensuring that they do get run.
    Gabriel Schulhof committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    07c0385 View commit details
    Browse the repository at this point in the history

  2. n-api: define release 6 

    Mark all N-APIs that have been added since version 5 as stable.

PR-URL: nodejs#32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @legendecas
    Gabriel Schulhof and legendecas committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    e1e2c2d View commit details
    Browse the repository at this point in the history