Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: implicit binds should be exclusive #325

Closed

Commits on Jan 13, 2015

  1. dgram: implicit binds should be exclusive

    Server sockets should be shared by default, and client sockets should be
    exclusive by default. For net/TCP, this is how it is, for dgram/UDP, its
    a little less clear what a client socket is, but a socket that is
    auto-bound during a dgram.send() is not usefully shared among cluster
    workers, any more than an outgoing TCP connection would be usefully
    shared.
    
    Since implicit binds become exclusive, implicit/client dgram sockets can
    now be used with cluster on Windows. Before, neither explicit nor
    implicitly bound sockets could be used, causing dgram to be completely
    unsupported with cluster on Windows. After this change, they become half
    supported.
    
    PR-URL: nodejs/node-v0.x-archive#8643
    Reviewed-by: Bert Belder <bertbelder@gmail.com>
    sam-github committed Jan 13, 2015
    Configuration menu
    Copy the full SHA
    3df18f0 View commit details
    Browse the repository at this point in the history