Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: revise test-http-response-multi-content-length #32526

Closed
wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 27, 2020

Isolate the two test cases here a bit more and refactor code.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30157/ (:yellow_heart:)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2020
Trott added a commit to Trott/io.js that referenced this pull request Mar 30, 2020
Isolate the two test cases here a bit more and refactor code.

PR-URL: nodejs#32526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott closed this Mar 30, 2020
@Trott
Copy link
Member Author

Trott commented Mar 30, 2020

Landed in c263784

@Trott Trott deleted the multi-content-length branch March 30, 2020 05:47
addaleax pushed a commit that referenced this pull request Mar 30, 2020
Isolate the two test cases here a bit more and refactor code.

PR-URL: #32526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Isolate the two test cases here a bit more and refactor code.

PR-URL: #32526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants