Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wordy phrase #32556

Closed
wants to merge 0 commits into from
Closed

Fix wordy phrase #32556

wants to merge 0 commits into from

Conversation

NotMoni
Copy link
Contributor

@NotMoni NotMoni commented Mar 29, 2020

Checklist
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 29, 2020
@himself65
Copy link
Member

commit message should be doc: fix ...

btw - [x] text is correct markdown format

  • text

@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

Ok will fix @himself65

NotMoni
NotMoni commented Mar 30, 2020
View reviewed changes
Copy link
Contributor Author

@NotMoni NotMoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc: fix wordy sentence

@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

I don't think I can change the commit name in this PR.

@pull pull bot closed this Mar 30, 2020
@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

@trot why was this closed ?

@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

Can we reopen this ?

@himself65
Copy link
Member

I think you rebase wrong. When no changes, PR will close automatically

@addaleax
Copy link
Member

Yeah … something probably went wrong when trying to update the commit message? You might also want to avoid making changes from your own master branch…

I don't think I can change the commit name in this PR.

You don’t have to, it’s optional to fix that up while the PR is open. It’s the responsibility of the person who merges the PR to ensure that the commit message matches our guidelines, not yours.

@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

Oh, ok. Let me fix this.

@NotMoni
Copy link
Contributor Author

NotMoni commented Mar 30, 2020

@addaleax and @Trott, Please check out #32567
Its the same PR but with the correct commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NotMoni @himself65 @addaleax @Trott @nodejs-github-bot