test: remove common.inspect() #3257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common.inspect() is just util.inspect(). common copies every property from util but this is the only one that gets used and it only gets used in three places. Well, four, but the fourth is removed in a pending PR. This commit removes it. Subsequently, the "copy util to common" part of `common` can be removed altogether.
|
I think we can remove those strings altogether. They may be used almost never and the tests might speed up a little. Also why not remove it from common? |
|
@thefourtheye Removing the strings entirely is a good idea, I think. I'll do that. Thanks for the suggestion. Can't remove it from common until both this and #3256 land. |
|
LGTM if the CI is green. |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 9, 2015
common.inspect() is just util.inspect(). common copies every property from util but this is the only one that gets used and it only gets used in three places. Well, four, but the fourth is removed in a pending PR. This commit removes it. Subsequently, the "copy util to common" part of `common` can be removed altogether. PR-URL: nodejs#3257 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Landed in 72c8a74. |
Trott
added a commit
that referenced
this pull request
Oct 10, 2015
common.inspect() is just util.inspect(). common copies every property from util but this is the only one that gets used and it only gets used in three places. Well, four, but the fourth is removed in a pending PR. This commit removes it. Subsequently, the "copy util to common" part of `common` can be removed altogether. PR-URL: #3257 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Landed in v4.x in f0f8afd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.inspect()is justutil.inspect().commoncopies every propertyfrom
utilbut this is the only one that gets used and it only gets usedin three files. Well, four, but the fourth is removed in a pending #3256.
This commit removes it. Subsequently, the "copy util to common"
part of
commoncan be removed altogether.