Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x] cli: allow --jitless V8 flag in NODE_OPTIONS #32594

Closed

Commits on Apr 1, 2020

  1. cli: allow --jitless V8 flag in NODE_OPTIONS

    This work is modeled on nodejs#30094 which allowed
    `--disallow-code-generation-from-strings` in `NODE_OPTIONS`.
    
    The `--jitless` v8 option has been supported since 12.0.0. As a v8
    option, node automatically picks it up, but there have been a few issues
    that were resolved by simply telling users about the option: nodejs#26758,
    
    This PR:
      - allows `--jitless` in `NODE_OPTIONS`
      - documents `--jitless`
      - moves `--experimental-loader=module` to locally restore alphabetical
        order in option documentation
    
    Refs: nodejs#30094
    Refs: nodejs#26758
    Refs: nodejs#28800
    
    PR-URL: nodejs#32100
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    andrewdotn authored and MylesBorins committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    0413aef View commit details
    Browse the repository at this point in the history
  2. Update test/parallel/test-cli-node-options.js

    Co-Authored-By: Anna Henningsen <github@addaleax.net>
    MylesBorins and addaleax committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    edcbef0 View commit details
    Browse the repository at this point in the history