Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve line-wrapping in net.md #32671

Merged
merged 1 commit into from
Apr 7, 2020
Merged

doc: improve line-wrapping in net.md #32671

merged 1 commit into from
Apr 7, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2020

Fix up a few instances that don't need to exceed 80 characters.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Apr 5, 2020
@Trott
Copy link
Member Author

Trott commented Apr 6, 2020

I guess the commit message isn't quite right. This doesn't exactly improve line-wrapping. It gets a bunch of lines under 80 chars without affecting rendering. Right now, the maximum line length lint rule is disabled for net.md, and this gets us close to being able to enable it.

@nodejs/documentation @nodejs/linting

Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe doc: remove optional parameter from markdown anchor link

Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: nodejs#32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 7, 2020

Landed in c849f2d

@Trott Trott merged commit c849f2d into nodejs:master Apr 7, 2020
@Trott Trott deleted the wrap-net branch April 7, 2020 22:19
targos pushed a commit that referenced this pull request Apr 12, 2020
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants