-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace console.log/error with debuglog #32695
Conversation
9b63eb6
to
d110688
Compare
Just a nit... the commit should use |
@jasnell updated 👍 |
This comment has been minimized.
This comment has been minimized.
d110688
to
20af0a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm sure this PR is ok but, I don't now why CI failed so many times(I'm a newbie on Jenkins CI) 🤔 |
This comment has been minimized.
This comment has been minimized.
Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js Refs: nodejs#32678
20af0a4
to
c993c4b
Compare
I will handle merging this |
@himself65 cool, thanks |
Landed in 41b1e87 Thanks for your contributions!🎉 |
BTW, the original commit message is invalid because ✖ da7d991c0221b662bf56a8d4861353237b84047e
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✖ 1:72 Line should be <= 72 columns. line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 5:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length so I edit it manually |
Use utility debug logs instead of console logs in
test-cluster-setup-master-multiple.js
Refs: #32678
Checklist
make -j4 test
(UNIX)