doc: updated guidance for n-api changes #32721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
cjihrig
approved these changes
Apr 8, 2020
legendecas
approved these changes
Apr 8, 2020
Trott
reviewed
Apr 13, 2020
Co-Authored-By: Rich Trott <rtrott@gmail.com>
|
Landed in 6c2c905 |
addaleax
pushed a commit
that referenced
this pull request
Apr 14, 2020
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs#32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Add js_native_api.h and js_native_api_types.h to the list of files covered by the N-API guidance as these were broken out of the files referenced. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add js_native_api.h and js_native_api_types.h to the list
of files covered by the N-API guidance as these were
broken out of the files referenced.
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes