-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: inline unbuffered _write #32886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
and should we add a comment like // inline doWrite(stream, state, false, len, chunk, encoding, cb)
for better understand
It's not exactly the same anymore, since some of the code that is not relevant is removed. So it might make it more confusing? |
PR-URL: #32886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in fd10be4 |
PR-URL: #32886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #32886 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
A ~15% improvement for the sync case
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes