Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: simplify Readable push/unshift logic #32899

Closed
wants to merge 1 commit into from
Closed

stream: simplify Readable push/unshift logic #32899

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30809/

@ronag
Copy link
Member

ronag commented Apr 17, 2020

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/555/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30951/

@addaleax
Copy link
Member

Benchmark CI looks good, no significant changes. 👍

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@addaleax
Copy link
Member

@himself65 Looks like this needs a rebase?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31081/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31083/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31084/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31085/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31089/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31093/

@himself65
Copy link
Member Author

https://ci.nodejs.org/job/node-test-commit-osx/33853/nodes=osx1015/testReport/(root)/test/sequential_test_cpu_prof_dir_worker_/

Error Message
flaky (1)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 29, 2020 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31096/ ✅

@ronag
Copy link
Member

ronag commented Apr 30, 2020

Landed in 0bd24a6

@ronag ronag closed this Apr 30, 2020
ronag pushed a commit that referenced this pull request Apr 30, 2020
@himself65 @ronag
stream: simplify Readable push/unshift logic
0bd24a6 
PR-URL: #32899
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 4, 2020
@himself65 @targos
stream: simplify Readable push/unshift logic
4cfa7e0 
PR-URL: #32899
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@himself65 @nodejs-github-bot @ronag @addaleax @jasnell @lpinca @BridgeAR @juanarbol @targos