Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: finished should complete with read-only Duplex #32967

Closed
wants to merge 3 commits into from
Closed

stream: finished should complete with read-only Duplex #32967

wants to merge 3 commits into from

Commits on Apr 21, 2020

  1. stream: finished should complete with read-only Duplex 

    If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.

Fixes: nodejs#32965
    @ronag
    ronag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    4a3d2db View commit details
    Browse the repository at this point in the history

  2. fixup: cast to boolean

    @ronag
    ronag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    e269eff View commit details
    Browse the repository at this point in the history

  3. fixup: another test + fix

    @ronag
    ronag committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    1fa3af2 View commit details
    Browse the repository at this point in the history