Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: correct typo in test name #33083

Closed
wants to merge 1 commit into from
Closed

test: correct typo in test name #33083

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 27, 2020

Fix the 'uncaugth' typo in the test name.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
test: correct typo in test name
f74b4de 
Fix the 'uncaugth' typo in the test name.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 27, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31026/ 💛

@addaleax
Copy link
Member

Landed in 11bc30d

addaleax pushed a commit that referenced this pull request Apr 29, 2020
@cjihrig @addaleax
test: correct typo in test name
11bc30d 
Fix the 'uncaugth' typo in the test name.

PR-URL: #33083
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@addaleax addaleax closed this Apr 29, 2020
@cjihrig cjihrig deleted the rename branch April 29, 2020 04:03
targos pushed a commit that referenced this pull request May 4, 2020
@cjihrig @targos
test: correct typo in test name
3c2f608 
Fix the 'uncaugth' typo in the test name.

PR-URL: #33083
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @addaleax @richardlau @gireeshpunathil @juanarbol @targos