Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: use free() to release preopen array #33110

Closed
wants to merge 1 commit into from
Closed

wasi: use free() to release preopen array #33110

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

As this is allocated with Calloc(), we cannot use delete[] here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
wasi: use free() to release preopen array
38373ec 
As this is allocated with `Calloc()`, we cannot use `delete[]` here.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface. labels Apr 28, 2020
@addaleax addaleax mentioned this pull request Apr 28, 2020
Closed
4 tasks
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 28, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31054/ (💛)

@addaleax
Copy link
Member Author

Landed in 526ff86

@addaleax addaleax closed this Apr 30, 2020
addaleax added a commit that referenced this pull request Apr 30, 2020
@addaleax
wasi: use free() to release preopen array
526ff86 
As this is allocated with `Calloc()`, we cannot use `delete[]` here.

PR-URL: #33110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax deleted the wasi-alloc-mismatch branch April 30, 2020 02:51
targos pushed a commit that referenced this pull request May 4, 2020
@addaleax @targos
wasi: use free() to release preopen array
3866dc1 
As this is allocated with `Calloc()`, we cannot use `delete[]` here.

PR-URL: #33110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 4, 2020
Merged
targos pushed a commit that referenced this pull request May 7, 2020
@addaleax @targos
wasi: use free() to release preopen array
8b7ff1c 
As this is allocated with `Calloc()`, we cannot use `delete[]` here.

PR-URL: #33110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 7, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@addaleax @targos
wasi: use free() to release preopen array
843a54f 
As this is allocated with `Calloc()`, we cannot use `delete[]` here.

PR-URL: #33110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @richardlau @devsnek