http: simplify sending header #33200
Conversation
unshifting into an empty array is the same as creating a new array.
ronag
added
the
author ready
|
I notice that benchmark CI has running for over 21 hours. any problems or it works as expected? |
It does that sometimes... I'll restart it https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/587/ |
|
@himself65 @ronag the issue is mainly the configuration of the benchmarks. Our default is set to run for five seconds per configuration for http benchmarks. This sums up easily (e.g., let's say a 2 * 3 * 2 matrix with five seconds each for 30 runs * 2 [before & after] = 12 * 60 * 5 seconds = 60 minutes). It is easy to calculate how long these benchmarks have to run to finish:
This has a total runtime of ~9 hours. This is an immense runtime for simple micro benchmarks. I suggest to drop as many configurations from the matrix as possible to reduce the runtime as well as reducing the duration from 5 to e.g., 3 seconds. Just the latter would reduce the runtime by ~3.5 hours. The reason why it shows up as e.g., 21 hours runtime is that the job has to wait for former benchmark runs to finish before it starts. This is done to reduce the overall load for our systems, since we have limited hardware resources. |
|
Landed in d799c0f |
unshifting into an empty array is the same as creating a new array. PR-URL: #33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
unshifting into an empty array is the same as creating a new array. PR-URL: #33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
unshifting into an empty array is the same as creating a new array. PR-URL: #33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
unshifting into an empty array is the same as creating a new array. PR-URL: #33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
unshifting into an empty array is the same as creating a new array. PR-URL: #33200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
unshifting into an empty array is the same as creating a new array.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes