n-api: add uint32 test for -1 #33241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
approved these changes
May 5, 2020
cjihrig
approved these changes
May 5, 2020
devnexen
approved these changes
May 5, 2020
himself65
approved these changes
May 5, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31179/ ✔️ (yellow) |
jasnell
approved these changes
May 6, 2020
|
Interestingly, no github actions were performed on this commit 🤨 |
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: nodejs#33117 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
gabrielschulhof
force-pushed
the
napi-get-value-uint32-with--1
branch
from
74ceba3 to
7923d9d
Compare
|
Touched the commit so as to trigger the actions. |
|
Landed in e454e9b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for
-1.
Re: #33117
Signed-off-by: @gabrielschulhof
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes