Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make temp path customizable #3325

Merged
merged 2 commits into from
Dec 30, 2015
Merged

test: make temp path customizable #3325

merged 2 commits into from
Dec 30, 2015

Commits on Dec 30, 2015

  1. test: make temp path customizable 

    In CI we previously passed `NODE_COMMON_PIPE` to the test runner to
avoid long filenames. Add an option to the test runner that allows the
user to change the temporary directory instead. This also allows us to
run test suites in parallel since `NODE_COMMON_PIPE` otherwise would
have been used from multiple tests at the same time.

PR-URL: nodejs#3325
Reviewed-By: Joao Reis <reis@janeasystems.com>
    @jbergstroem
    jbergstroem committed Dec 30, 2015
    Configuration menu
    Copy the full SHA
    8132b94 View commit details
    Browse the repository at this point in the history

  2. test: don't assume a certain folder structure 

    A few tests assumed that temp dirs always lived in the same
parent folder as fixtures. Make these use `common.tmpDir` instead.

PR-URL: nodejs#3325
Reviewed-By: Joao Reis <reis@janeasystems.com>
    @jbergstroem
    jbergstroem committed Dec 30, 2015
    Configuration menu
    Copy the full SHA
    842e5a1 View commit details
    Browse the repository at this point in the history