Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: deprecate duplicated repl features #33294

Closed
wants to merge 3 commits into from
Closed

repl: deprecate duplicated repl features #33294

wants to merge 3 commits into from

Commits on May 15, 2020

  1. repl: deprecate repl.inputStream and repl.outputStream 

    The stream is exposed twice. As such it's best to rely upon the
.input and .output properties set by readline.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    @BridgeAR
    BridgeAR committed May 15, 2020
    Configuration menu
    Copy the full SHA
    b32f1ae View commit details
    Browse the repository at this point in the history

  2. repl: remove obsolete completer variable 

    It is also assigned in readline. There is not need to assign the
variable twice.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    @BridgeAR
    BridgeAR committed May 15, 2020
    Configuration menu
    Copy the full SHA
    bae3a62 View commit details
    Browse the repository at this point in the history

  3. repl: deprecate repl._builtinLibs 

    This is a manually edited and outdated list of builtin modules.
Instead, it is better to rely upon the officially documented way
to get a list of builtin modules.

As a side by fix this makes sure all exports are in one place. Thus,
it is easier to see what parts are actually exported and which are
not.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
    @BridgeAR
    BridgeAR committed May 15, 2020
    Configuration menu
    Copy the full SHA
    369d494 View commit details
    Browse the repository at this point in the history