Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: show keylen in pbkdf2 as a byte length #3334

Closed
wants to merge 1 commit into from
Closed

doc: show keylen in pbkdf2 as a byte length #3334

wants to merge 1 commit into from

Conversation

calebboyd
Copy link
Contributor

Ensure that keylen for pbkdf2 is documented as a length of bytes and not bits

@Trott Trott added doc Issues and PRs related to the documentations. crypto Issues and PRs related to the crypto subsystem. labels Oct 13, 2015
@jasnell
Copy link
Member

jasnell commented Oct 14, 2015

@indutny @shigeki

@indutny
Copy link
Member

indutny commented Oct 14, 2015

LGTM

@Fishrock123
Copy link
Contributor

@calebboyd Your git signing email is set to <calebboyd@users.noreply.github.com> is that ok?

You can change this by doing:

git config --global user.email "your_email@example.com"

git commit --amend --reset-author --no-edit

And then force-pushing to this branch. :)

Ensure that keylen for pbkdf2 is documented as a length of bytes and not
bits
@calebboyd
Copy link
Contributor Author

Aha, Thanks. I edited it in github, fixed.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Oct 19, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not
bits.

PR-URL: nodejs#3334
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks! Landed in ff8fa51 :)

rvagg pushed a commit that referenced this pull request Oct 21, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not
bits.

PR-URL: #3334
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Oct 21, 2015
jasnell pushed a commit that referenced this pull request Oct 26, 2015
Ensure that keylen for pbkdf2 is documented as a length of bytes and not
bits.

PR-URL: #3334
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 26, 2015

landed in v4.x-staging in 925953d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants