repl: support --loader option in builtin REPL #33437

targos · 2020-05-16T14:34:05Z

I'll try to write a test if there are no objections to the change.

/cc @nodejs/modules-active-members

targos · 2020-05-16T14:38:20Z

With the example from the issue:

$ echo 'console.log("hooks executing")' > hooks.mjs
$ ./node --loader ./hooks.mjs
(node:1190852) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
hooks executing
Welcome to Node.js v15.0.0-pre.
Type ".help" for more information.

With a wrong path:

$ ./node --loader ./hooks.js
(node:1190903) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
internal/main/repl.js:70
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/mzasso/git/nodejs/node/hooks.js' imported from /home/mzasso/git/nodejs/node/
    at finalizeResolution (internal/modules/esm/resolve.js:284:11)
    at moduleResolve (internal/modules/esm/resolve.js:662:10)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:752:11)
    at Loader.resolve (internal/modules/esm/loader.js:97:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:242:28)
    at Loader.import (internal/modules/esm/loader.js:177:28)
    at internal/process/esm_loader.js:55:31
    at Object.initializeLoader (internal/process/esm_loader.js:60:5)
    at internal/main/repl.js:37:13 {
  code: 'ERR_MODULE_NOT_FOUND'

With error in the loader code:

$ echo 'throw new Error("test")' > hooks.mjs
$ ./node --loader ./hooks.mjs
(node:1190987) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
file:///home/mzasso/git/nodejs/node/hooks.mjs:1
throw new Error("test")
      ^

Error: test
    at file:///home/mzasso/git/nodejs/node/hooks.mjs:1:7
    at ModuleJob.run (internal/modules/esm/module_job.js:138:23)
    at async Loader.import (internal/modules/esm/loader.js:178:24)
    at async internal/process/esm_loader.js:55:9

lib/internal/main/repl.js

BridgeAR

I am fine with adding this feature. It would be good in general to support esm better in the REPL.

lib/internal/main/repl.js

devsnek · 2020-05-16T22:20:43Z

Maybe this is too heavy for this pr, but refactoring internal/process/esm_loader to gate exposing the loader instance behind a function which also ensures the loader is properly initialized would be nice.

BridgeAR · 2020-05-27T23:40:57Z

Ping @targos

targos · 2020-05-29T18:13:12Z

Updated with a different approach. PTAL.

devsnek · 2020-05-29T18:16:17Z

lib/internal/process/esm_loader.js

+
+exports.loadESM = async function loadESM(callback) {
+  try {
+    await initializeLoader();


should probably gate this on ESMLoader being undefined

do you mean add something like assert(ESMLoader === undefined) ?

yeah that works.

I can't. There's a default loader defined above, and removing it breaks things.

BridgeAR

LGTM

nodejs-github-bot · 2020-05-31T09:36:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31669/

nodejs-github-bot · 2020-06-06T10:37:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31748/

nodejs-github-bot · 2020-06-16T07:52:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31883/

nodejs-github-bot · 2020-06-16T07:52:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31884/

Fixes: nodejs#33435

nodejs-github-bot · 2020-07-14T08:08:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32325/

nodejs-github-bot · 2020-07-14T08:57:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32326/

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos · 2020-07-14T13:21:45Z

Landed in 05539c1

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

codebytere · 2020-09-27T17:29:13Z

@targos could you please backport this to v12.x?

Fixes: nodejs#33435 PR-URL: nodejs#33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: #33435 PR-URL: #33437 Backport-PR-URL: #35394 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos mentioned this pull request May 16, 2020

node --loader for REPL (without entrypoint) does not execute loader #33435

Closed

ljharb reviewed May 16, 2020

View reviewed changes

lib/internal/main/repl.js Outdated Show resolved Hide resolved

lib/internal/main/repl.js Outdated Show resolved Hide resolved

lib/internal/main/repl.js Outdated Show resolved Hide resolved

BridgeAR reviewed May 16, 2020

View reviewed changes

lib/internal/main/repl.js Outdated Show resolved Hide resolved

targos force-pushed the repl-loader branch from a42fbf0 to 4f00b09 Compare May 29, 2020 18:10

devsnek approved these changes May 29, 2020

View reviewed changes

BridgeAR approved these changes May 29, 2020

View reviewed changes

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18

This was referenced Jun 4, 2020

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#3

Closed

CI Relability 2020-06-04 JaneaSystems/nodejs-reliability#4

Open

CI Relability 2020-06-05 JaneaSystems/nodejs-reliability#5

Open

CI Relability 2020-06-06 JaneaSystems/nodejs-reliability#6

Open

This was referenced Jun 7, 2020

CI Relability 2020-06-07 JaneaSystems/nodejs-reliability#7

Open

CI Relability 2020-06-08 JaneaSystems/nodejs-reliability#8

Open

targos force-pushed the repl-loader branch from 4f00b09 to fd16758 Compare June 16, 2020 07:52

repl: support --loader option in builtin REPL

dc45738

Fixes: nodejs#33435

targos force-pushed the repl-loader branch from fd16758 to dc45738 Compare July 14, 2020 08:05

targos added a commit that referenced this pull request Jul 14, 2020

repl: support --loader option in builtin REPL

05539c1

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos closed this Jul 14, 2020

targos deleted the repl-loader branch July 14, 2020 13:21

MylesBorins pushed a commit that referenced this pull request Jul 14, 2020

repl: support --loader option in builtin REPL

e5da23e

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins mentioned this pull request Jul 14, 2020

v14.6.0 proposal #34371

Merged

This was referenced Jul 15, 2020

CI Relability 2020-07-15 JaneaSystems/nodejs-reliability#38

Open

CI Relability 2020-07-16 JaneaSystems/nodejs-reliability#39

Open

MylesBorins pushed a commit that referenced this pull request Jul 16, 2020

repl: support --loader option in builtin REPL

73d6792

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced Jul 17, 2020

CI Relability 2020-07-17 JaneaSystems/nodejs-reliability#40

Open

CI Relability 2020-07-18 JaneaSystems/nodejs-reliability#41

Open

CI Relability 2020-07-19 JaneaSystems/nodejs-reliability#42

Open

CI Relability 2020-07-20 JaneaSystems/nodejs-reliability#43

Open

cjihrig pushed a commit that referenced this pull request Jul 23, 2020

repl: support --loader option in builtin REPL

7ca70e4

Fixes: #33435 PR-URL: #33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

codebytere added the backport-requested-v12.x label Sep 27, 2020

targos added backport-open-v12.x and removed backport-requested-v12.x labels Sep 28, 2020

targos added a commit to targos/node that referenced this pull request Sep 28, 2020

repl: support --loader option in builtin REPL

ee7cae2

Fixes: nodejs#33435 PR-URL: nodejs#33437 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos mentioned this pull request Sep 28, 2020

[v12.x backport] repl: support --loader option in builtin REPL #35394

Closed

addaleax pushed a commit that referenced this pull request Sep 28, 2020

repl: support --loader option in builtin REPL

b7be751

Fixes: #33435 PR-URL: #33437 Backport-PR-URL: #35394 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

codebytere mentioned this pull request Oct 4, 2020

v12.19.0 proposal #35401

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: support --loader option in builtin REPL #33437

repl: support --loader option in builtin REPL #33437

targos commented May 16, 2020 •

edited

Loading

targos commented May 16, 2020

BridgeAR left a comment

devsnek commented May 16, 2020

BridgeAR commented May 27, 2020

targos commented May 29, 2020

devsnek May 29, 2020

targos May 29, 2020

devsnek May 29, 2020

targos May 30, 2020

BridgeAR left a comment

nodejs-github-bot commented May 31, 2020

nodejs-github-bot commented Jun 6, 2020

nodejs-github-bot commented Jun 16, 2020

nodejs-github-bot commented Jun 16, 2020

nodejs-github-bot commented Jul 14, 2020

nodejs-github-bot commented Jul 14, 2020

targos commented Jul 14, 2020

codebytere commented Sep 27, 2020

repl: support --loader option in builtin REPL #33437

repl: support --loader option in builtin REPL #33437

Conversation

targos commented May 16, 2020 • edited Loading

targos commented May 16, 2020

BridgeAR left a comment

Choose a reason for hiding this comment

devsnek commented May 16, 2020

BridgeAR commented May 27, 2020

targos commented May 29, 2020

devsnek May 29, 2020

Choose a reason for hiding this comment

targos May 29, 2020

Choose a reason for hiding this comment

devsnek May 29, 2020

Choose a reason for hiding this comment

targos May 30, 2020

Choose a reason for hiding this comment

BridgeAR left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented May 31, 2020

nodejs-github-bot commented Jun 6, 2020

nodejs-github-bot commented Jun 16, 2020

nodejs-github-bot commented Jun 16, 2020

nodejs-github-bot commented Jul 14, 2020

nodejs-github-bot commented Jul 14, 2020

targos commented Jul 14, 2020

codebytere commented Sep 27, 2020

targos commented May 16, 2020 •

edited

Loading