util: fix inspection of class instance prototypes #33449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
encoding
|
remember to use |
devsnek
reviewed
May 17, 2020
devsnek
reviewed
May 17, 2020
|
@nodejs/util PTAL |
BridgeAR
requested review from
targos,
devsnek,
antsmartian,
benjamingr,
jasnell and
mcollina
|
This could use some reviews. Not sure whom else to ping. |
antsmartian
added
the
author ready
targos
approved these changes
May 23, 2020
benjamingr
approved these changes
May 23, 2020
To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Fixes: nodejs#33419 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33449 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
force-pushed
the
fix-proto-inspection
branch
from
3f8d01e to
8bb164d
Compare
|
@benjamingr if you would like anything changed, please comment. I am happy to follow-up on those. |
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 25, 2020
To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33449 Fixes: nodejs#33419 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in e24731c |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33449 Fixes: #33419 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33449 Fixes: #33419 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
@BridgeAR should this go back to v12.x? Looks like it'll need a manual backport if yes - if not just remove the label :) |
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve this, some internal custom inspect functions had to be
changed. They relied upon the former behavior.
Fixes: #33419
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes