Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: refactor and enable poll_oneoff() test #33521

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 23, 2020

This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020

@cjihrig
Copy link
Contributor Author

cjihrig commented May 24, 2020

@nodejs/wasi ping for another review

Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: nodejs#33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: nodejs#33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cjihrig cjihrig merged commit a4e6ef7 into nodejs:master May 25, 2020
@cjihrig
Copy link
Contributor Author

cjihrig commented May 25, 2020

Landed in c072124...a4e6ef7. Thanks for the reviews!

@cjihrig cjihrig deleted the poll-test branch May 25, 2020 13:46
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
Original commit message:

    poll_oneoff: add missing uv_run() in cleanup

    This allows ASAN to pass.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
This commit refactors and enables the poll_oneoff() WASI test.
The refactor includes testing additional cases, as well as some
platform specific checks.

PR-URL: #33521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere added a commit that referenced this pull request Jul 13, 2020
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 14, 2020
Notable changes:

deps:
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 16, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 17, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * V8: cherry-pick eec10a2fd8fa (Stephen Belanger) [#33778](#33778)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 21, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 21, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 22, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
codebytere added a commit that referenced this pull request Jul 22, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [#34246](#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [#33447](#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](#33521)

PR-URL: #34343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants