Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: simplify WASI memory management #33525

Merged
merged 1 commit into from
May 25, 2020
Merged

wasi: simplify WASI memory management #33525

merged 1 commit into from
May 25, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 23, 2020

This commit migrates the WASI C++ code from UncheckedCalloc() to std::vectors. Should help with code coverage as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface. labels May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31480/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31506/ 💚

@cjihrig
Copy link
Contributor Author

cjihrig commented May 24, 2020

@nodejs/wasi ping for another review

@cjihrig
wasi: simplify WASI memory management
698267c 
This commit migrates the WASI C++ code from UncheckedCalloc()
to std::vectors.

PR-URL: nodejs#33525
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig cjihrig merged commit 698267c into nodejs:master May 25, 2020
@cjihrig cjihrig deleted the wasi-mem branch May 25, 2020 13:49
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@cjihrig @codebytere
wasi: simplify WASI memory management
5eecea3 
This commit migrates the WASI C++ code from UncheckedCalloc()
to std::vectors.

PR-URL: #33525
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@cjihrig @codebytere
wasi: simplify WASI memory management
58cf43b 
This commit migrates the WASI C++ code from UncheckedCalloc()
to std::vectors.

PR-URL: #33525
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@cjihrig @codebytere
wasi: simplify WASI memory management
33984d6 
This commit migrates the WASI C++ code from UncheckedCalloc()
to std::vectors.

PR-URL: #33525
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @bnoordhuis @addaleax @gengjiawen @devnexen @BridgeAR