Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buffer.md #33547

Closed
wants to merge 2 commits into from
Closed

Update buffer.md #33547

wants to merge 2 commits into from

Conversation

tomanagle
Copy link
Contributor

@tomanagle tomanagle commented May 24, 2020 •
edited
Loading

Fixes the sentence structure by removing a floating s and offsets the interrupting in general with commas.

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels May 24, 2020
@BridgeAR BridgeAR requested a review from Trott May 25, 2020 06:31
Trott
Trott reviewed May 27, 2020
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
Trott
Trott previously requested changes May 27, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma position needs to be restored.

@tomanagle @Trott
Update doc/api/buffer.md
f0b0525 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR dismissed Trott’s stale review May 30, 2020 00:52

The blocking comment is addressed as requested. PTAL

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
@tomanagle @BridgeAR
doc: improve buffer.md a tiny bit
5e77c67 
PR-URL: nodejs#33547
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR
Copy link
Member

Landed in 5e77c67

@BridgeAR BridgeAR closed this May 30, 2020
@Trott
Copy link
Member

Trott commented May 31, 2020

Belated LGTM. Thanks for the fix!

codebytere pushed a commit that referenced this pull request Jun 18, 2020
@tomanagle @codebytere
doc: improve buffer.md a tiny bit
c184929 
PR-URL: #33547
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@tomanagle @codebytere
doc: improve buffer.md a tiny bit
66312b0 
PR-URL: #33547
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@tomanagle @codebytere
doc: improve buffer.md a tiny bit
5416635 
PR-URL: #33547
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomanagle @BridgeAR @Trott @jasnell @gireeshpunathil @nodejs-github-bot