Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: set target property to null #33615

Closed
wants to merge 1 commit into from
Closed

events: set target property to null #33615

wants to merge 1 commit into from

Conversation

benjamingr
Copy link
Member

Another small fix to set the target property of the event to null and not undefined (to align behaviors)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr requested review from jasnell and targos May 28, 2020 14:44
@benjamingr benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31604/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2020
@benjamingr benjamingr force-pushed the event-target-target-null branch from 1dd2055 to 474f586 Compare May 30, 2020 11:30
benjamingr added a commit that referenced this pull request May 31, 2020
@benjamingr
events: set target property to null
b2b95eb 
PR-URL: #33615
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@benjamingr
Copy link
Member Author

benjamingr commented May 31, 2020 •
edited by BridgeAR
Loading

Landed in b2b95eb 🎉

@benjamingr benjamingr closed this May 31, 2020
@benjamingr benjamingr deleted the event-target-target-null branch May 31, 2020 10:30
@targos
Copy link
Member

targos commented May 31, 2020

@benjamingr I don't know which of the PRs you just landed introduced it, but there's a linter error on master now: https://github.com/nodejs/node/runs/724700725

@benjamingr
Copy link
Member Author

@targos my bad, this is the first time I used the node core utils flow and I probably messed something up. Should I force-push a fix?

@benjamingr
Copy link
Member Author

I will force push and make a PSA, sorry!

@benjamingr
Copy link
Member Author

benjamingr commented May 31, 2020 •
edited
Loading

@targos I am having issues, I am dealing with it, it will take 5 more minutes. My computer just crashed and ncu kicked me out :(

@benjamingr
Copy link
Member Author

@targos can you please check I did things correctly? I landed things for the first time in ±2 years and for the first time with NCU. Ruben helped me for most parts but I think I still made a mess somehow and I'm not sure I understand what happened.

I will just wait for Ruben to be online and then investigate with him and make a PSA in the meantime.

@BridgeAR
Copy link
Member

Seems like it's still on master. The issue is this commit f643cf4

@benjamingr benjamingr restored the event-target-target-null branch May 31, 2020 12:16
@BridgeAR BridgeAR reopened this May 31, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 5, 2020
Open
8 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@benjamingr benjamingr force-pushed the event-target-target-null branch from 50ef651 to 2738e94 Compare June 5, 2020 22:57
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31742/

jasnell pushed a commit that referenced this pull request Jun 5, 2020
@benjamingr @jasnell
events: set target property to null
1969ada 
PR-URL: #33615
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 5, 2020

Landed in 1969ada

This was referenced Jan 25, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 27, 2022
Open
This was referenced Sep 27, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Sep 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 28, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 28, 2022
Open
This was referenced Sep 28, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Jun 23, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jun 23, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jun 24, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 24, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 15, 2023
Open
Open
@baby636 baby636 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@himself65 himself65 himself65 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benjamingr @nodejs-github-bot @targos @BridgeAR @jasnell @himself65 @juanarbol @addaleax