test: uv_tty_init now returns EINVAL on IBM i #33629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338.
richardlau
approved these changes
May 29, 2020
richardlau
added
the
author ready
BridgeAR
approved these changes
May 29, 2020
cjihrig
approved these changes
May 30, 2020
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
|
Landed in 7774458. |
richardlau
pushed a commit
that referenced
this pull request
Jun 1, 2020
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338. PR-URL: #33629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338. PR-URL: #33629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338. PR-URL: #33629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338. PR-URL: #33629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338.
Based on the comment -- libuv/libuv#2753 (comment)