-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: don't emit error for stream destroyed #33654
Conversation
72c7eac
to
734bf3a
Compare
@nodejs/http @nodejs/web-server-frameworks |
8ae28ff
to
2935f72
Compare
b152c48
to
a21385e
Compare
unsure about the semversiness of this one. |
a21385e
to
48a58b1
Compare
92d8ad6
to
73b6a74
Compare
Should this land in the next v14.x release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, crossing fingers we do not break anything.
0d71e89
to
7191d18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7191d18
to
402fc26
Compare
This needs another CI run + CITGM |
Landed in 30cc542 |
This doesn't land cleanly on v14.x. @ronag would you be willing to backport? |
Should this be backported with #32933 ? |
Yes. I'm a little overloaded at the moment though. If you need help ping me again in a. week :). |
Aligns with streams
Refs: #33591
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes