Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix compiling addons with older versions of Node.js #33688

Merged
merged 1 commit into from
Jun 4, 2020
Merged

build: fix compiling addons with older versions of Node.js #33688

merged 1 commit into from
Jun 4, 2020

Commits on Jun 4, 2020

  1. build: fix compiling addons with older versions of Node.js 

    `common.gypi` is used by `node-gyp` to compile addons. Default values
must be provided for variables that may not exist on older versions of
Node.js so that older versions of Node.js can be used to compile addons
for later versions of Node.js.

Add default values for `v8_enable_pointer_compression` and
`v8_enable_31bit_smis_on_64bit_arch`.

PR-URL: nodejs#33688
Refs: nodejs#30463
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
    @richardlau
    richardlau committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a1e5fd2 View commit details
    Browse the repository at this point in the history