doc: add lint disabling comment for collaborator list #33719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
disable-for-collab-list
branch
2 times, most recently
from
60a8ba0
to
03bea59
Compare
|
Would like to fast track this because nodejs/remark-preset-lint-node#96 is blocked until this lands. Collaborators, please 👍 here to fast-track. |
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: nodejs#33688 Refs: nodejs#30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>
richardlau
approved these changes
Jun 4, 2020
cjihrig
approved these changes
Jun 4, 2020
BethGriggs
approved these changes
Jun 4, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: nodejs#33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: #33719 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable linting for prohibited strings in the collaborator list so that
sam-github does not have to be sam-GitHub.
Refs: nodejs/remark-preset-lint-node#96
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes