New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: apply native V8 join for better performance #33737

Closed

sapics wants to merge 1 commit into nodejs:master from sapics:lib/array-join

Contributor

sapics commented Jun 5, 2020

As reported in #33732, built-in Array#join is faster than lib/internal/util.js#join function.
This PR would close #33732.

Checklist

commit message follows commit guidelines


          lib: apply native V8 join for better performance

216a2cd

nodejs-github-bot added the util label

sapics closed this

sapics mentioned this pull request

lib/internal/util.js#join function is slower than the built-in Array#join #33732

Closed

sapics deleted the lib/array-join branch

June 19, 2020 01:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

util