Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify default encoding in writable.write #33765

Closed
wants to merge 2 commits into from
Closed

doc: specify default encoding in writable.write #33765

wants to merge 2 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jun 6, 2020

Refs: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 6, 2020
Trott
Trott reviewed Jun 6, 2020
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
@rexagod @Trott
Update doc/api/stream.md
c6b7f8d 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 6, 2020
jasnell pushed a commit that referenced this pull request Jun 19, 2020
@rexagod @jasnell
doc: specify default encoding in writable.write
9dcde52 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

Landed in 9dcde52

@jasnell jasnell closed this Jun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 22, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
76fe2a9 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
8bc1f66 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
3789c28 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@rexagod @codebytere
doc: specify default encoding in writable.write
e5a1ca2 
Refs: #33715

PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSlimCoder MrSlimCoder MrSlimCoder approved these changes

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rexagod @jasnell @Trott @lpinca @trivikr @MrSlimCoder @nodejs-github-bot