Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: stop testing --interpreted-frames-native-stack for s390x" #33794

Closed
wants to merge 1 commit into from
Closed

Revert "test: stop testing --interpreted-frames-native-stack for s390x" #33794

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 8, 2020

Revert "test: stop testing --interpreted-frames-native-stack for s390x"

This reverts commit 38fd93c.

Refs: #33702

@nodejs/platform-s390

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 8, 2020
@targos targos mentioned this pull request Jun 8, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31774/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2020
This was referenced Jun 9, 2020
Open
Open
targos added a commit that referenced this pull request Jun 12, 2020
@targos
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
76ceaff 
This reverts commit 38fd93c.

Refs: #33702

PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
Copy link
Member Author

targos commented Jun 12, 2020

Landed in 76ceaff

@targos targos closed this Jun 12, 2020
@targos targos deleted the revert-s390 branch June 12, 2020 13:49
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@targos @codebytere
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
b8fdde4 
This reverts commit 38fd93c.

Refs: #33702

PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@targos @codebytere
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
bce2bba 
This reverts commit 38fd93c.

Refs: #33702

PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @addaleax @richardlau @BethGriggs