quic: remove noop code

[ronag]

this.unidirectional depends on #id which is never set in the constructor, hence this condition will never run and should be possible to removed.

I'm probably missing something here? I guess this might be more of a question in the form of a PR. However, the tests seem to pass.

My original intent was to try and remove the explicit push/end and instead send in readable/writable to the Duplex.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

make -j4 && python tools/test.py -J --mode=release parallel/test-quic-* is that enough to run quic related tests?

[jasnell]

Yep, I believe this is a remnant from a prior refactoring that changed when the #id was set so we should be safe in removing this. FWIW, after we get past the openjs world conference and collaborator summit next week, I plan on revisiting all of the JavaScript code in here and doing a major refactoring. Obviously, feel free to keep making PRs changing bits but there a large portion of this that I fully expect to see changed.

[jasnell]

make -j4 && python tools/test.py -J --mode=release parallel/test-quic-* is that enough to run quic related tests?

Make sure you ./configure --experimental-quic first, then yes, that works for running the necessary tests.

[ronag]

I plan on revisiting all of the JavaScript code in here and doing a major refactoring

Cool. I'll make some draft PR's as some kind of post merge review, against my repo and ping you. At least on the streams part I would like to give some feedback on what I'd propose to change/improve.

Please give me a shout out once you are past your refactoring and I'll do dig in.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31899/

[ronag]

@jasnell Does CI run with --experimental-quic?

[richardlau]

Does CI run with --experimental-quic?

It does not. You could always run node-test-commit or one of the more platform specific node-test-commit-* jobs (i.e. not the node-test-pull-request job) with a custom CONFIG_FLAGS build parameter.

[jasnell]

See also: nodejs/build#2353

[jasnell]

Landed in 16116f5