test: print arguments passed to mustNotCall function #33951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com>
3 tasks
devsnek
approved these changes
Jun 18, 2020
lundibundi
added
the
author ready
Trott
approved these changes
Jun 19, 2020
trivikr
approved these changes
Jun 20, 2020
jasnell
approved these changes
Jun 24, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 24, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 225a03c |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Refs: #33949 (comment) Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: #33951 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #33949 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/testing