test: account for non-node basename #33952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 19, 2020
jasnell
approved these changes
Jun 19, 2020
|
Landed in 46ee864 |
codebytere
added a commit
that referenced
this pull request
Jun 22, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
that referenced
this pull request
Jun 27, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
that referenced
this pull request
Jul 10, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
that referenced
this pull request
Jul 12, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33952 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 23, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs edf75e4.
Electron runs smoke tests with Node.js' own specs against our emulated version of Node.js, and so it's the case for us that the basename is
Electron. These tests were failing as they're hardcoded to assume it'snodeso this makes them more flexible for embedders.cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes