Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix lexical sorting of bottom-references in http doc #34007

Closed
wants to merge 1 commit into from
Closed

doc: fix lexical sorting of bottom-references in http doc #34007

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jun 22, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 22, 2020
@rexagod
Copy link
Member Author

rexagod commented Jun 22, 2020

ping @Trott

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 24, 2020
jasnell pushed a commit that referenced this pull request Jun 24, 2020
@rexagod @jasnell
doc: fix lexical sorting of bottom-references in http doc
4af2539 
PR-URL: #34007
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 24, 2020

Landed in 4af2539

@jasnell jasnell closed this Jun 24, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@rexagod @codebytere
doc: fix lexical sorting of bottom-references in http doc
0dbad26 
PR-URL: #34007
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod @codebytere
doc: fix lexical sorting of bottom-references in http doc
2fe5622 
PR-URL: #34007
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rexagod @jasnell @Trott @lpinca @trivikr @addaleax @nodejs-github-bot