timers: allow timers to be used as primitives #34017

lundibundi · 2020-06-22T14:49:14Z

This allows timers to be matched to numeric Ids and therefore used
as keys of an Object, passed and stored without storing the Timer instance.

clearTimeout/clearInterval is modified to support numeric/string Ids.

Co-authored-by: Bradley Farias bradley.meck@gmail.com
Co-authored-by: Anatoli Papirovski apapirovski@mac.com

Refs: #21152

Continuing great work of @bmeck and @apapirovski. Noticed this PR, checked the benchmarks and they looked just fine with almost no impact now. See results on my machine below

Object.create(null) benchmark

 ➔ dev/node/node cat compare-timer-obj-str.csv | Rscript benchmark/compare.R                                                 

                                                              confidence improvement accuracy (*)    (**)   (***)
 timers/immediate.js type='breadth' n=5000000                                -1.21 %       ±3.23%  ±4.33%  ±5.69%
 timers/immediate.js type='breadth1' n=5000000                               -1.80 %       ±4.25%  ±5.69%  ±7.49%
 timers/immediate.js type='breadth4' n=5000000                               -3.73 %       ±6.41%  ±8.58% ±11.29%
 timers/immediate.js type='clear' n=5000000                            *     -4.99 %       ±4.69%  ±6.28%  ±8.26%
 timers/immediate.js type='depth' n=5000000                                  -0.45 %       ±3.93%  ±5.26%  ±6.92%
 timers/immediate.js type='depth1' n=5000000                                 -2.77 %       ±3.01%  ±4.03%  ±5.31%
 timers/set-immediate-breadth-args.js n=5000000                               1.00 %       ±3.88%  ±5.19%  ±6.83%
 timers/set-immediate-breadth.js n=10000000                                   2.76 %       ±4.35%  ±5.83%  ±7.68%
 timers/set-immediate-depth-args.js n=5000000                                -1.65 %       ±4.92%  ±6.60%  ±8.69%
 timers/timers-breadth-args.js n=1000000                                     -0.01 %       ±6.71%  ±9.00% ±11.85%
 timers/timers-breadth.js n=5000000                                          -0.95 %       ±5.75%  ±7.70% ±10.13%
 timers/timers-cancel-pooled.js n=5000000                                     3.28 %       ±9.96% ±13.34% ±17.54%
 timers/timers-cancel-unpooled.js direction='end' n=1000000                   4.13 %       ±9.31% ±12.48% ±16.44%
 timers/timers-cancel-unpooled.js direction='start' n=1000000                -1.79 %       ±7.95% ±10.66% ±14.05%
 timers/timers-depth.js n=1000                                                0.28 %       ±1.24%  ±1.66%  ±2.20%
 timers/timers-insert-pooled.js n=5000000                                    -0.01 %       ±3.06%  ±4.10%  ±5.39%
 timers/timers-insert-unpooled.js direction='end' n=1000000                  -0.19 %       ±1.38%  ±1.84%  ±2.43%
 timers/timers-insert-unpooled.js direction='start' n=1000000                 0.21 %       ±2.11%  ±2.83%  ±3.72%
 timers/timers-timeout-nexttick.js n=50000                                   -6.10 %       ±8.16% ±10.95% ±14.44%
 timers/timers-timeout-nexttick.js n=5000000                                 -1.78 %       ±4.68%  ±6.27%  ±8.25%
 timers/timers-timeout-pooled.js n=10000000                                   0.50 %       ±5.02%  ±6.73%  ±8.85%
 timers/timers-timeout-unpooled.js n=1000000                                  3.26 %       ±9.15% ±12.28% ±16.18%

I've also tried to use Map and it show slightly worse performance for some reason.

Map benchmark

 ➔ dev/node/node cat compare-timer-map-str.csv | Rscript benchmark/compare.R                                                

                                                              confidence improvement accuracy (*)   (**)  (***)
 timers/immediate.js type='breadth' n=5000000                          *      2.40 %       ±1.97% ±2.65% ±3.49%
 timers/immediate.js type='breadth1' n=5000000                               -0.83 %       ±1.83% ±2.47% ±3.27%
 timers/immediate.js type='breadth4' n=5000000                               -2.01 %       ±3.36% ±4.50% ±5.93%
 timers/immediate.js type='clear' n=5000000                                  -0.82 %       ±2.74% ±3.68% ±4.85%
 timers/immediate.js type='depth' n=5000000                                   0.57 %       ±0.87% ±1.16% ±1.53%
 timers/immediate.js type='depth1' n=5000000                                 -0.12 %       ±1.40% ±1.89% ±2.50%
 timers/set-immediate-breadth-args.js n=5000000                              -0.76 %       ±1.72% ±2.32% ±3.08%
 timers/set-immediate-breadth.js n=10000000                                   0.53 %       ±4.10% ±5.49% ±7.22%
 timers/set-immediate-depth-args.js n=5000000                                 0.18 %       ±0.97% ±1.30% ±1.71%
 timers/timers-breadth-args.js n=1000000                               *     -4.43 %       ±3.39% ±4.55% ±5.98%
 timers/timers-breadth.js n=5000000                                          -1.42 %       ±2.95% ±3.96% ±5.20%
 timers/timers-cancel-pooled.js n=5000000                              *      2.81 %       ±2.70% ±3.62% ±4.77%
 timers/timers-cancel-unpooled.js direction='end' n=1000000            *     -2.91 %       ±2.71% ±3.65% ±4.86%
 timers/timers-cancel-unpooled.js direction='start' n=1000000         **     -4.62 %       ±2.64% ±3.54% ±4.66%
 timers/timers-depth.js n=1000                                               -0.06 %       ±0.87% ±1.16% ±1.53%
 timers/timers-insert-pooled.js n=5000000                                    -0.05 %       ±2.56% ±3.43% ±4.51%
 timers/timers-insert-unpooled.js direction='end' n=1000000                   0.05 %       ±1.92% ±2.57% ±3.38%
 timers/timers-insert-unpooled.js direction='start' n=1000000                -1.05 %       ±2.15% ±2.88% ±3.78%
 timers/timers-timeout-nexttick.js n=50000                                   -0.49 %       ±3.32% ±4.45% ±5.87%
 timers/timers-timeout-nexttick.js n=5000000                                  0.15 %       ±1.60% ±2.15% ±2.85%
 timers/timers-timeout-pooled.js n=10000000                            *     -1.22 %       ±1.20% ±1.62% ±2.14%
 timers/timers-timeout-unpooled.js n=1000000                           *     -4.14 %       ±3.23% ±4.34% ±5.74%

I didn't try the holey array as that would require using parseInt on passed strings to get the original number Id and could possibly add unnecessary overhead/unexpected errors to clearTimeout.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

/cc @nodejs/timers

nodejs-github-bot · 2020-06-22T14:50:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32020/
Benchmarks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/622/

Fishrock123

Generally seems fine to me, though I think the lack of compatibility with worker_threads will probably decrease its usefulness. I also do not see any good way around that though.

lib/timers.js

lundibundi · 2020-06-22T18:28:10Z

@Fishrock123

Generally seems fine to me, though I think the lack of compatibility with worker_threads will probably decrease its usefulness. I also do not see any good way around that though.

Hm, I thought a somewhat simple wrapper for setTimeout would suffice to handle that use case.
i.e. Have Map of timerId to some workerId in the main thread, make custom setTimeout that would store\remove ids from Map upon addition/removal of timers (in main tread) and make appropriate calls in sub-threads via messages to the main thread that would then post message for addition/removal to correct thread.
It should be also possible to make that peer-to-peer where each thread handles local timers and makes broadcasts to other threads and probably uses some cache of timer-to-worker to avoid unnecessary broadcasts.

There are multiple options and trade-offs to make while implementing that so I'd not do it in core unless we find a nice way to connect async_hooks with worker_threads.

lib/internal/timers.js

nodejs-github-bot · 2020-06-22T21:14:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32036/

lundibundi · 2020-06-22T21:16:04Z

Benchmark CI results are kind of weird (11% improvement of timers/timers-timeout-nexttick.js for no reason) but not too bad.

19:22:12                                                               confidence improvement accuracy (*)    (**)   (***)
19:22:12  timers/immediate.js type='breadth1' n=5000000                                1.17 %       ±4.69%  ±6.24%  ±8.12%
19:22:12  timers/immediate.js type='breadth4' n=5000000                               -0.86 %       ±3.45%  ±4.59%  ±5.98%
19:22:12  timers/immediate.js type='breadth' n=5000000                                -1.90 %       ±2.80%  ±3.73%  ±4.86%
19:22:12  timers/immediate.js type='clear' n=5000000                          ***     -3.67 %       ±2.05%  ±2.73%  ±3.55%
19:22:12  timers/immediate.js type='depth1' n=5000000                                  0.03 %       ±1.44%  ±1.92%  ±2.50%
19:22:12  timers/immediate.js type='depth' n=5000000                            *      2.48 %       ±2.43%  ±3.25%  ±4.27%
19:22:12  timers/set-immediate-breadth-args.js n=5000000                              -0.93 %       ±4.16%  ±5.54%  ±7.22%
19:22:12  timers/set-immediate-breadth.js n=10000000                                   0.77 %       ±4.63%  ±6.16%  ±8.03%
19:22:12  timers/set-immediate-depth-args.js n=5000000                                 1.18 %       ±2.23%  ±2.96%  ±3.86%
19:22:12  timers/timers-breadth-args.js n=1000000                                     -0.54 %       ±3.32%  ±4.41%  ±5.75%
19:22:12  timers/timers-breadth.js n=5000000                                          -1.93 %       ±3.89%  ±5.18%  ±6.75%
19:22:12  timers/timers-cancel-pooled.js n=5000000                                     1.38 %      ±10.68% ±14.20% ±18.49%
19:22:12  timers/timers-cancel-unpooled.js direction='end' n=1000000                   2.73 %      ±24.47% ±32.55% ±42.37%
19:22:12  timers/timers-cancel-unpooled.js direction='start' n=1000000                 6.99 %       ±9.75% ±12.97% ±16.89%
19:22:12  timers/timers-depth.js n=1000                                         *     -0.19 %       ±0.17%  ±0.23%  ±0.29%
19:22:12  timers/timers-insert-pooled.js n=5000000                                    -2.97 %       ±3.90%  ±5.19%  ±6.77%
19:22:12  timers/timers-insert-unpooled.js direction='end' n=1000000                   0.91 %       ±4.79%  ±6.37%  ±8.30%
19:22:12  timers/timers-insert-unpooled.js direction='start' n=1000000                -1.97 %       ±4.11%  ±5.47%  ±7.13%
19:22:12  timers/timers-timeout-nexttick.js n=50000                           ***     11.91 %       ±3.43%  ±4.57%  ±5.96%
19:22:12  timers/timers-timeout-nexttick.js n=5000000                                 -0.06 %       ±6.98%  ±9.29% ±12.10%
19:22:12  timers/timers-timeout-pooled.js n=10000000                                   5.76 %      ±10.09% ±13.43% ±17.48%
19:22:12  timers/timers-timeout-unpooled.js n=1000000                          **     -7.03 %       ±4.54%  ±6.08%  ±8.00%

ZYSzys · 2020-06-23T07:23:45Z

@lundibundi This needs a rebase.

This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Co-authored-by: Anatoli Papirovski <apapirovski@mac.com> Refs: nodejs#21152

nodejs-github-bot · 2020-06-23T08:18:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32040/

benjamingr · 2020-06-23T10:31:29Z

@itayperry

nodejs-github-bot · 2020-06-24T22:31:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32052/

This allows timers to be matched to numeric Ids and therefore used as keys of an Object, passed and stored without storing the Timer instance. clearTimeout/clearInterval is modified to support numeric/string Ids. Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Co-authored-by: Anatoli Papirovski <apapirovski@mac.com> Refs: #21152 PR-URL: #34017 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell · 2020-06-24T23:16:28Z

Landed in ca46c3b

Notable changes: assert: * (SEMVER-MINOR) port common.mustCall() to assert (ConorDavenport) #31982 async_hooks: * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) #34574 buffer: * (SEMVER-MINOR) also alias BigUInt methods (Anna Henningsen) #34960 * (SEMVER-MINOR) alias UInt ➡️ Uint in buffer methods (Anna Henningsen) #34729 build: * (SEMVER-MINOR) add build flag for OSS-Fuzz integration (davkor) #34761 cli: * (SEMVER-MINOR) add alias for report-directory to make it consistent (Ash Cripps) #33587 crypto: * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360 * (SEMVER-MINOR) add randomInt function (Oli Lalonde) #34600 deps: * upgrade to libuv 1.39.0 (Colin Ihrig) #34915 * upgrade npm to 6.14.7 (claudiahdz) #34468 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413 doc: * (SEMVER-MINOR) Add maxTotalSockets option to agent constructor (rickyes) #33617 * (SEMVER-MINOR) add basic embedding example documentation (Anna Henningsen) #30467 * add Ricky Zhou to collaborators (rickyes) #34676 * add release key for Ruy Adorno (Ruy Adorno) #34628 * add DerekNonGeneric to collaborators (Derek Lewis) #34602 * add AshCripps to collaborators (Ash Cripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 * (SEMVER-MAJOR) deprecate process.umask() with no arguments (Colin Ihrig) #32499 embedding: * (SEMVER-MINOR) make Stop() stop Workers (Anna Henningsen) #32531 * (SEMVER-MINOR) provide hook for custom process.exit() behaviour (Anna Henningsen) #32531 fs: * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399 http: * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617 * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789 * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803 http2: * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994 * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160 module: * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 n-api: * (SEMVER-MINOR) create N-API version 7 (Gabriel Schulhof) #35199 * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) #28237 n-api,src: * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) #34572 perf_hooks: * (SEMVER-MINOR) add idleTime and event loop util (Trevor Norris) #34938 timers: * (SEMVER-MINOR) allow timers to be used as primitives (Denys Otrishko) #34017 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 worker: * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979 * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772 * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772 * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772 * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) add stack size resource limit option (Anna Henningsen) #33085 worker,fs: * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772 zlib: * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516 * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) port common.mustCall() to assert (ConorDavenport) #31982 async_hooks: * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) #34574 buffer: * (SEMVER-MINOR) also alias BigUInt methods (Anna Henningsen) #34960 * (SEMVER-MINOR) alias UInt ➡️ Uint in buffer methods (Anna Henningsen) #34729 build: * (SEMVER-MINOR) add build flag for OSS-Fuzz integration (davkor) #34761 cli: * (SEMVER-MINOR) add alias for report-directory to make it consistent (Ash Cripps) #33587 crypto: * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) #33360 * (SEMVER-MINOR) add randomInt function (Oli Lalonde) #34600 deps: * upgrade to libuv 1.39.0 (Colin Ihrig) #34915 * upgrade npm to 6.14.7 (claudiahdz) #34468 * upgrade to libuv 1.38.1 (Colin Ihrig) #34187 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) #14500 * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) #22413 doc: * (SEMVER-MINOR) Add maxTotalSockets option to agent constructor (rickyes) #33617 * (SEMVER-MINOR) add basic embedding example documentation (Anna Henningsen) #30467 * add Ricky Zhou to collaborators (rickyes) #34676 * add release key for Ruy Adorno (Ruy Adorno) #34628 * add DerekNonGeneric to collaborators (Derek Lewis) #34602 * add AshCripps to collaborators (Ash Cripps) #34494 * add HarshithaKP to collaborators (Harshitha K P) #34417 * add rexagod to collaborators (Pranshu Srivastava) #34457 * add release key for Richard Lau (Richard Lau) #34397 * add danielleadams to collaborators (Danielle Adams) #34360 * add sxa as collaborator (Stewart X Addison) #34338 * add ruyadorno to collaborators (Ruy Adorno) #34297 * (SEMVER-MAJOR) deprecate process.umask() with no arguments (Colin Ihrig) #32499 embedding: * (SEMVER-MINOR) make Stop() stop Workers (Anna Henningsen) #32531 * (SEMVER-MINOR) provide hook for custom process.exit() behaviour (Anna Henningsen) #32531 fs: * (SEMVER-MINOR) implement lutimes (Maël Nison) #33399 http: * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) #33617 * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) #32789 * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) #33803 http2: * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) #33994 * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) #33160 module: * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 * (SEMVER-MINOR) package "imports" field (Guy Bedford) #34117 * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) #32217 n-api: * (SEMVER-MINOR) create N-API version 7 (Gabriel Schulhof) #35199 * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) #28237 n-api,src: * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) #34572 perf_hooks: * (SEMVER-MINOR) add idleTime and event loop util (Trevor Norris) #34938 timers: * (SEMVER-MINOR) allow timers to be used as primitives (Denys Otrishko) #34017 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) #33974 worker: * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) #33979 * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) #33772 * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) #33772 * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) #33772 * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) #34303 * (SEMVER-MINOR) add stack size resource limit option (Anna Henningsen) #33085 worker,fs: * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) #33772 zlib: * (SEMVER-MINOR) add `maxOutputLength` option (unknown) #33516 * switch to lazy init for zlib streams (Andrey Pechkurov) #34048 PR-URL: #35401

Notable changes: assert: * (SEMVER-MINOR) port common.mustCall() to assert (ConorDavenport) nodejs#31982 async_hooks: * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) nodejs#34574 buffer: * (SEMVER-MINOR) also alias BigUInt methods (Anna Henningsen) nodejs#34960 * (SEMVER-MINOR) alias UInt ➡️ Uint in buffer methods (Anna Henningsen) nodejs#34729 build: * (SEMVER-MINOR) add build flag for OSS-Fuzz integration (davkor) nodejs#34761 cli: * (SEMVER-MINOR) add alias for report-directory to make it consistent (Ash Cripps) nodejs#33587 crypto: * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) add randomInt function (Oli Lalonde) nodejs#34600 deps: * upgrade to libuv 1.39.0 (Colin Ihrig) nodejs#34915 * upgrade npm to 6.14.7 (claudiahdz) nodejs#34468 * upgrade to libuv 1.38.1 (Colin Ihrig) nodejs#34187 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) nodejs#14500 * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) nodejs#22413 doc: * (SEMVER-MINOR) Add maxTotalSockets option to agent constructor (rickyes) nodejs#33617 * (SEMVER-MINOR) add basic embedding example documentation (Anna Henningsen) nodejs#30467 * add Ricky Zhou to collaborators (rickyes) nodejs#34676 * add release key for Ruy Adorno (Ruy Adorno) nodejs#34628 * add DerekNonGeneric to collaborators (Derek Lewis) nodejs#34602 * add AshCripps to collaborators (Ash Cripps) nodejs#34494 * add HarshithaKP to collaborators (Harshitha K P) nodejs#34417 * add rexagod to collaborators (Pranshu Srivastava) nodejs#34457 * add release key for Richard Lau (Richard Lau) nodejs#34397 * add danielleadams to collaborators (Danielle Adams) nodejs#34360 * add sxa as collaborator (Stewart X Addison) nodejs#34338 * add ruyadorno to collaborators (Ruy Adorno) nodejs#34297 * (SEMVER-MAJOR) deprecate process.umask() with no arguments (Colin Ihrig) nodejs#32499 embedding: * (SEMVER-MINOR) make Stop() stop Workers (Anna Henningsen) nodejs#32531 * (SEMVER-MINOR) provide hook for custom process.exit() behaviour (Anna Henningsen) nodejs#32531 fs: * (SEMVER-MINOR) implement lutimes (Maël Nison) nodejs#33399 http: * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) nodejs#33617 * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) nodejs#33803 http2: * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) nodejs#33994 * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) nodejs#33160 module: * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) nodejs#35249 * (SEMVER-MINOR) exports pattern support (Guy Bedford) nodejs#34718 * (SEMVER-MINOR) package "imports" field (Guy Bedford) nodejs#34117 * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) nodejs#32217 n-api: * (SEMVER-MINOR) create N-API version 7 (Gabriel Schulhof) nodejs#35199 * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) nodejs#28237 n-api,src: * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) nodejs#34572 perf_hooks: * (SEMVER-MINOR) add idleTime and event loop util (Trevor Norris) nodejs#34938 timers: * (SEMVER-MINOR) allow timers to be used as primitives (Denys Otrishko) nodejs#34017 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) nodejs#33974 worker: * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) nodejs#33979 * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) nodejs#34303 * (SEMVER-MINOR) add stack size resource limit option (Anna Henningsen) nodejs#33085 worker,fs: * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) nodejs#33772 zlib: * (SEMVER-MINOR) add `maxOutputLength` option (unknown) nodejs#33516 * switch to lazy init for zlib streams (Andrey Pechkurov) nodejs#34048 PR-URL: nodejs#35401

nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Jun 22, 2020

jasnell approved these changes Jun 22, 2020

View reviewed changes

bmeck approved these changes Jun 22, 2020

View reviewed changes

Fishrock123 approved these changes Jun 22, 2020

View reviewed changes

lib/timers.js Show resolved Hide resolved

addaleax approved these changes Jun 22, 2020

View reviewed changes

lib/internal/timers.js Outdated Show resolved Hide resolved

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 22, 2020

lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 22, 2020

github-actions bot mentioned this pull request Jun 23, 2020

CI Relability 2020-06-23 JaneaSystems/nodejs-reliability#16

Open

29 tasks

trivikr approved these changes Jun 23, 2020

View reviewed changes

ZYSzys approved these changes Jun 23, 2020

View reviewed changes

lundibundi force-pushed the timer-to-primitive branch from aceb09f to 36f0340 Compare June 23, 2020 08:17

benjamingr approved these changes Jun 23, 2020

View reviewed changes

github-actions bot mentioned this pull request Jun 24, 2020

CI Relability 2020-06-24 JaneaSystems/nodejs-reliability#17

Open

13 tasks

jasnell closed this Jun 24, 2020

Trott mentioned this pull request Oct 23, 2020

Change in return value of setTimeout #35770

Closed

apapirovski mentioned this pull request Jun 11, 2021

typings: add JSDoc typings for timers #38834

Closed

137717unity mentioned this pull request May 22, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#95

Open

snyk-bot mentioned this pull request May 23, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#95

Open

wedataintelligence mentioned this pull request May 24, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#77

Open

baby636 mentioned this pull request May 24, 2023

[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#92

Open

aliceUnhinged613 mentioned this pull request Nov 25, 2023

[Snyk] Fix for 28 vulnerabilities aliceUnhinged613/node#98

Open

wedataintelligence mentioned this pull request Nov 28, 2023

[Snyk] Fix for 28 vulnerabilities wedataintelligence/node#87

Open

baby636 mentioned this pull request Nov 28, 2023

[Snyk] Fix for 37 vulnerabilities baby636/node#110

Open

ron-a20 mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities ron-a20/node#112

Open

137717unity mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities 137717unity/node#113

Open

wedataintelligence mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities wedataintelligence/node#96

Open

aliceUnhinged613 mentioned this pull request Dec 19, 2023

[Snyk] Fix for 30 vulnerabilities aliceUnhinged613/node#114

Open

baby636 mentioned this pull request Dec 20, 2023

[Snyk] Fix for 43 vulnerabilities baby636/node#126

Open

137717unity mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 137717unity/node#125

Open

aliceUnhinged613 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 aliceUnhinged613/node#125

Open

ron-a20 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 ron-a20/node#123

Open

molllyn1 mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 molllyn1/node#109

Open

kissofire mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.2.13 to 3.15.0 kissofire/node#126

Open

wedataintelligence mentioned this pull request Apr 14, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.3.10 to 3.15.0 wedataintelligence/node#108

Open

baby636 mentioned this pull request Apr 15, 2024

[Snyk] Security upgrade gatsby-plugin-sharp from 2.6.24 to 3.15.0 baby636/node#146

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

timers: allow timers to be used as primitives #34017

timers: allow timers to be used as primitives #34017

lundibundi commented Jun 22, 2020

nodejs-github-bot commented Jun 22, 2020 •

edited by lundibundi

Loading

Fishrock123 left a comment

lundibundi commented Jun 22, 2020

nodejs-github-bot commented Jun 22, 2020

lundibundi commented Jun 22, 2020

ZYSzys commented Jun 23, 2020

nodejs-github-bot commented Jun 23, 2020

benjamingr commented Jun 23, 2020

nodejs-github-bot commented Jun 24, 2020

jasnell commented Jun 24, 2020

timers: allow timers to be used as primitives #34017

timers: allow timers to be used as primitives #34017

Conversation

lundibundi commented Jun 22, 2020

Checklist

nodejs-github-bot commented Jun 22, 2020 • edited by lundibundi Loading

Fishrock123 left a comment

Choose a reason for hiding this comment

lundibundi commented Jun 22, 2020

nodejs-github-bot commented Jun 22, 2020

lundibundi commented Jun 22, 2020

ZYSzys commented Jun 23, 2020

nodejs-github-bot commented Jun 23, 2020

benjamingr commented Jun 23, 2020

nodejs-github-bot commented Jun 24, 2020

jasnell commented Jun 24, 2020

nodejs-github-bot commented Jun 22, 2020 •

edited by lundibundi

Loading