util: add `util/types` alias module #34055

ExE-Boss · 2020-06-25T17:18:06Z

This should be the last alias module, unless we also want to add alias modules for the constants exports.

Refs: #31553
Refs: #32953
Refs: #33950
Refs: #34001
Refs: #34002
Refs: #34962

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

jasnell · 2020-06-25T18:10:46Z

unless we also want to add alias modules for the constants exports.

Definite -1 on that ;-)

targos

This should also be documented in a more visible way than the "changes:" section.

Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002

ExE-Boss · 2020-08-12T15:43:56Z

Can we get this into v15.0?

ExE-Boss · 2020-08-28T23:33:45Z

There’s also the path.posix and path.win32 namespaces that would also benefit from alias modules: #34962.

Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002 Refs: nodejs#34055

ExE-Boss · 2020-10-08T18:11:00Z

@jasnell @targos
Can we please get this merged?

MylesBorins

RSLGTM

ExE-Boss · 2020-10-12T17:15:46Z

review?(@mcollina, @tniessen, @Trott)

Trott · 2020-10-13T18:49:37Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2515/ (queued, will 404 until it starts)

ExE-Boss · 2020-10-18T19:43:26Z

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

Trott · 2020-10-18T22:32:52Z

@jasnell @MylesBorins @Trott @targos @BridgeAR

It’s only a few days left until v15.0.0 ships, and I’d like to get this merged before then.

We're a few weeks past the semver-major cut-off date for 15.x.x so this would probably require assent from both @nodejs/tsc and Releasers (and in particular @BethGriggs who is preparing the release) to land in 15.x.x.

@richardlau Is this semver major because it might have a naming clash with existing modules? Or is there another reason?

aduh95 · 2020-10-20T23:27:06Z

Landed in c2ceb15

Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 PR-URL: #34055 Refs: #34962 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Fixes: nodejs#35740 Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33991 Refs: nodejs#34001 Refs: nodejs#34055 Refs: nodejs#34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com>

Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #34002 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 Refs: #34055 PR-URL: #34962 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Refs: #31553 Refs: #32953 Refs: #33950 Refs: #34001 Refs: #34002 PR-URL: #34055 Refs: #34962 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Notable changes: dns: * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099 events: * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001 http: * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048 http2: * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978 lib: * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716 path: * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962 readline: * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675 src: * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940 util: * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055 PR-URL: TODO

Notable changes: dns: * (SEMVER-MINOR) add a cancel() method to the promise Resolver (Szymon Marczak) #33099 events: * (SEMVER-MINOR) add max listener warning for EventTarget (James M Snell) #36001 http: * (SEMVER-MINOR) add support for abortsignal to http.request (Benjamin Gruenbaum) #36048 http2: * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) #35978 lib: * (SEMVER-MINOR) add throws option to fs.f/l/statSync (Andrew Casey) #33716 path: * (SEMVER-MINOR) add `path/posix` and `path/win32` alias modules (ExE Boss) #34962 readline: * (SEMVER-MINOR) add getPrompt to get the current prompt (Mattias Runge-Broberg) #33675 src: * (SEMVER-MINOR) add loop idle time in diagnostic report (Gireesh Punathil) #35940 util: * (SEMVER-MINOR) add `util/types` alias module (ExE Boss) #34055 PR-URL: #36232

Fixes: #35740 Refs: #31553 Refs: #32953 Refs: #33991 Refs: #34001 Refs: #34055 Refs: #34962 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #34002 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 25, 2020

ExE-Boss force-pushed the lib/util/add-util-types-alias-module branch from ec57841 to 8272c46 Compare June 25, 2020 17:18

jasnell approved these changes Jun 25, 2020

View reviewed changes

richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 25, 2020

This comment has been minimized.

Sign in to view

targos requested changes Jun 27, 2020

View reviewed changes

util: add util/types alias module

86bc1db

Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002

ExE-Boss force-pushed the lib/util/add-util-types-alias-module branch from 8272c46 to 86bc1db Compare June 27, 2020 13:40

ExE-Boss requested a review from targos June 27, 2020 13:47

targos approved these changes Jun 27, 2020

View reviewed changes

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020

This comment has been minimized.

Sign in to view

ExE-Boss mentioned this pull request Aug 28, 2020

path: add path/posix and path/win32 alias modules #34962

Closed

4 tasks

ExE-Boss mentioned this pull request Sep 29, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

guybedford mentioned this pull request Oct 3, 2020

Node.js core alias modules jspm/jspm-core#11

Closed

ExE-Boss mentioned this pull request Oct 6, 2020

Node.js Technical Steering Committee (TSC) Meeting 2020-10-08 nodejs/TSC#935

Closed

ExE-Boss added a commit to ExE-Boss/node that referenced this pull request Oct 6, 2020

path: add path/posix and path/win32 alias modules

4c75a27

Refs: nodejs#31553 Refs: nodejs#32953 Refs: nodejs#33950 Refs: nodejs#34001 Refs: nodejs#34002 Refs: nodejs#34055

MylesBorins approved these changes Oct 8, 2020

View reviewed changes

BridgeAR approved these changes Oct 8, 2020

View reviewed changes

Trott approved these changes Oct 13, 2020

View reviewed changes

aduh95 closed this Oct 20, 2020

rickyes removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 21, 2020

ExE-Boss deleted the lib/util/add-util-types-alias-module branch October 21, 2020 10:57

ExE-Boss mentioned this pull request Oct 21, 2020

doc: document changes for */promises alias modules #34002

Closed

2 tasks

ExE-Boss mentioned this pull request Oct 24, 2020

Backporting util/types, path/posix and path/win32 to v15 proposal #35788

Closed

targos added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Nov 11, 2020

codebytere mentioned this pull request Nov 22, 2020

v15.3.0 proposal #36232

Merged

targos added dont-land-on-v12.x labels Aug 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: add `util/types` alias module #34055

util: add `util/types` alias module #34055

ExE-Boss commented Jun 25, 2020 •

edited

Loading

jasnell commented Jun 25, 2020

This comment has been minimized.

targos left a comment

ExE-Boss commented Aug 12, 2020

This comment has been minimized.

ExE-Boss commented Aug 28, 2020

ExE-Boss commented Oct 8, 2020

MylesBorins left a comment

ExE-Boss commented Oct 12, 2020

Trott commented Oct 13, 2020

ExE-Boss commented Oct 18, 2020

Trott commented Oct 18, 2020

aduh95 commented Oct 20, 2020

util: add util/types alias module #34055

util: add util/types alias module #34055

Conversation

ExE-Boss commented Jun 25, 2020 • edited Loading

Checklist

jasnell commented Jun 25, 2020

This comment has been minimized.

targos left a comment

Choose a reason for hiding this comment

ExE-Boss commented Aug 12, 2020

This comment has been minimized.

ExE-Boss commented Aug 28, 2020

ExE-Boss commented Oct 8, 2020

MylesBorins left a comment

Choose a reason for hiding this comment

ExE-Boss commented Oct 12, 2020

Trott commented Oct 13, 2020

ExE-Boss commented Oct 18, 2020

Trott commented Oct 18, 2020

aduh95 commented Oct 20, 2020

util: add `util/types` alias module #34055

util: add `util/types` alias module #34055

ExE-Boss commented Jun 25, 2020 •

edited

Loading